Skip to content

Graduate FIFO and Redis cache from experimental #7314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
friedrichg merged 2 commits into from
Mar 4, 2026
Merged

Graduate FIFO and Redis cache from experimental #7314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a354205
Graduate FIFO and Redis cache from experimental
friedrichg Mar 3, 2026
7c3c7da
Merge branch 'master' into graduate-fifo-redis-cache
friedrichg Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion docs/configuration/v1-guarantees.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ Currently experimental features are:
- API (enabled via `-experimental.alertmanager.enable-api`)
- Sharding of tenants across multiple instances (enabled via `-alertmanager.sharding-enabled`)
- Receiver integrations firewall (configured via `-alertmanager.receivers-firewall.*`)
- In-memory (FIFO) and Redis cache.
- gRPC Store.
- TLS configuration in gRPC and HTTP clients.
- TLS configuration in Etcd client.
Expand Down
3 changes: 0 additions & 3 deletions pkg/chunk/cache/fifo_cache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ import (
"github.com/prometheus/client_golang/prometheus/promauto"

"github.com/cortexproject/cortex/pkg/util/flagext"
util_log "github.com/cortexproject/cortex/pkg/util/log"
)

const (
Expand Down Expand Up @@ -93,8 +92,6 @@ type cacheEntry struct {

// NewFifoCache returns a new initialised FifoCache of size.
func NewFifoCache(name string, cfg FifoCacheConfig, reg prometheus.Registerer, logger log.Logger) *FifoCache {
util_log.WarnExperimentalUse("In-memory (FIFO) cache")

if cfg.DeprecatedSize > 0 {
flagext.DeprecatedFlagsUsed.Inc()
level.Warn(logger).Log("msg", "running with DEPRECATED flag fifocache.size, use fifocache.max-size-items or fifocache.max-size-bytes instead", "cache", name)
Expand Down
1 change: 0 additions & 1 deletion pkg/chunk/cache/redis_cache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ type RedisCache struct {

// NewRedisCache creates a new RedisCache
func NewRedisCache(name string, redisClient *RedisClient, reg prometheus.Registerer, logger log.Logger) *RedisCache {
util_log.WarnExperimentalUse("Redis cache")
cache := &RedisCache{
name: name,
redis: redisClient,
Expand Down
Loading