Skip to content

go get -u && go mod tidy#125

Merged
wader merged 1 commit intocortesi:masterfrom
wader:go-mod-update-tidy
Mar 23, 2026
Merged

go get -u && go mod tidy#125
wader merged 1 commit intocortesi:masterfrom
wader:go-mod-update-tidy

Conversation

@wader
Copy link
Copy Markdown
Collaborator

@wader wader commented Jun 24, 2025

No description provided.

@wader
Copy link
Copy Markdown
Collaborator Author

wader commented Jun 24, 2025

Would be nice to cleanup/remove some dependencies so would be good to get this merged first

@wader wader force-pushed the go-mod-update-tidy branch from 1022708 to 01dbc6b Compare March 23, 2026 09:50
@wader
Copy link
Copy Markdown
Collaborator Author

wader commented Mar 23, 2026

This seems to also fix some cgo build warnings

@wader
Copy link
Copy Markdown
Collaborator Author

wader commented Mar 23, 2026

@chebread looks good?

Comment thread go.mod
module github.com/cortesi/devd

go 1.12
go 1.25.0
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have 1.26.1 locally but seem this is what tidy wants

@chebread
Copy link
Copy Markdown
Contributor

1.25.0 is perfectly fine. In my opinion, the go 1.25.0 directive just sets the minimum required version, so keeping it at 1.25.0 rather than 1.26.1 allows for broader compatibility for anyone still on Go 1.25.

I also pulled this PR, built the binary, and tested it locally. Everything works perfectly without any issues.

Let's merge this!

@wader wader merged commit 3d8bc22 into cortesi:master Mar 23, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants