Feat/optional codecs, HTJ2K support#391
Open
jmhmd wants to merge 11 commits intocornerstonejs:masterfrom
jmhmd:feat/optional-codecs-htj2k
Open
Feat/optional codecs, HTJ2K support#391jmhmd wants to merge 11 commits intocornerstonejs:masterfrom jmhmd:feat/optional-codecs-htj2k
jmhmd wants to merge 11 commits intocornerstonejs:masterfrom
jmhmd:feat/optional-codecs-htj2k
Conversation
Add JPH codec
- move web worker initialization into main configure fuction - define codecs to be loaded in main configuration one time for either workers or main thread
Fix examples
- was corrupted during rebase
Member
|
Thanks! I have some codec work on my plate very soon so I'll try to find out how to get this stuff in with it. We are also interested in htj2k and adding codecs one by one so our goals are aligned :-) |
Contributor
Author
|
That's great to hear! Looking forward to it. Happy to discuss any of these proposed changes or strategies as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR reconfigures the image decompression codecs such that they can be included piecemeal or all at once. The use case is for applications that only handle one or several known transfer syntaxes, and these can only included the necessary codec and thus reduce the javascript bundle size. This also includes support for HTJ2K compressed images. Sorry about formatting changes in some of the Markdown files thanks to my editor auto-formatting.
Breaking changes
configure()functionallDecoders.jsfile is provided for convenience.docs/Migration.mdHTJ2K
This adds support for loading HTJ2K compressed images using the emscripten build from Chris Hafey here. See documentation in
docs/HTJ2K.md. There may be other approaches to how to best load these as HTJ2K is not a standardized transfer syntax, and I am open to opinions.Not sure if this should be a separate pull request, but I was working on both at the same time. I think it could pretty easily be removed and submitted separately if that's preferred.