treewide: remove RockyJS support#899
Merged
gmarull merged 1 commit intocoredevices:mainfrom Mar 17, 2026
Merged
Conversation
gmarull
force-pushed
the
bye-bye-rockyjs
branch
from
53c0f07 to
685d5e8
Compare
Member
Author
|
jplexer
requested changes
Mar 6, 2026
Member
jplexer
left a comment
jplexer
left a comment
There was a problem hiding this comment.
the one exported API should be kept, but stubbed. other than that lgtm
| { | ||
| "_comment": "Marked as deprecated so that the function it self won't appear in pebble.h", | ||
| "type": "function", | ||
| "name": "rocky_event_loop_with_resource", |
Member
There was a problem hiding this comment.
Dont remove from SDK, replace with stub instead, since there are existing apps that use rocky
gmarull
force-pushed
the
bye-bye-rockyjs
branch
from
d3e1f27 to
22b080d
Compare
gmarull
force-pushed
the
bye-bye-rockyjs
branch
from
22b080d to
e05562a
Compare
gmarull
force-pushed
the
bye-bye-rockyjs
branch
from
e05562a to
8530774
Compare
Member
|
fyi, switch to upstream moddable (tag 7.2.0/public branch) then this should be gtg |
gmarull
force-pushed
the
bye-bye-rockyjs
branch
from
8530774 to
dbb28a3
Compare
Member
Author
looks like they haven't picked the changes... |
Member
|
grrrrr. |
Member
Author
|
@phoddie could you please merge our patches into mainline? |
gmarull
force-pushed
the
bye-bye-rockyjs
branch
2 times, most recently
from
c71725a to
39342f6
Compare
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
gmarull
force-pushed
the
bye-bye-rockyjs
branch
from
39342f6 to
ce7b3cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.