feature: Add country flag for public IP#537
Open
azadevlab wants to merge 1 commit intocorecoding:developfrom
Open
feature: Add country flag for public IP#537azadevlab wants to merge 1 commit intocorecoding:developfrom
azadevlab wants to merge 1 commit intocorecoding:developfrom
Conversation
Author
|
@corecoding hi Chris, please could you check this MR and merge it? closes #488 (comment) |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
using MR style like - #494
Summary
This MR -
PLEASE PAY ATTENTION THAT schemas was updated, YOU HAVE TO RE-COMPILE schemas/gschemas.compiled
glib-compile-schemas schemas/Old situation
no country flag for Public IP
New situation
country flag for IP can be set
Changes Made
added checkbox "Show country flag"
added box for setting Public IP update interval (min 1 , max 1440)
Testing
No startup errors
No errors during adding/removing items or when changing settings
Screenshots/Visual Changes
