Fix #286: Fall Particles on Neoforge now correctly use the block material.#393
Open
squeeglii wants to merge 1 commit into
Open
Fix #286: Fall Particles on Neoforge now correctly use the block material.#393squeeglii wants to merge 1 commit into
squeeglii wants to merge 1 commit into
Conversation
squeeglii
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #286 - from what I understand,
addLandingEffectunder NeoForge is used for creating custom fall particles for blocks outside of what is defined inside of block models. This method is optional, though, so any block without non-model particles would fall back to vanilla particles, which would use the missing texture.I looked at fabric 1.20.1 too and that seems to be fine.