Resolve client crash while building chunk meshes#386
Open
deadly-pudding wants to merge 1 commit into
Open
Conversation
Copycats was encountering a null pointer exception here while trying to build chunks in Neoforge 21.1.228.
Author
|
I couldn't get the null pointer error that this fixes to reproduce when I copied my world and modpack (with the unaltered copycats+ 3.0.4 release) to a local single-player install for further testing, so that's fun. But it's probably still worth checking for the null here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copycats was encountering a null pointer exception here while the client was trying to build chunks in Neoforge 21.1.228. See #371
Further testing is still needed to see if a different crash also occurs once this fix is in place.