vine: add vine_plot_run batch plot driver#4388
Open
JinZhou5042 wants to merge 1 commit intocooperative-computing-lab:masterfrom
Open
vine: add vine_plot_run batch plot driver#4388JinZhou5042 wants to merge 1 commit intocooperative-computing-lab:masterfrom
JinZhou5042 wants to merge 1 commit intocooperative-computing-lab:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
For #4355
Adds
vine_plot_run, a small driver that runs the usual TaskVine plotting tools (vine_plot_txn_log,vine_plot_performance,vine_plot_compose, and optionallyvine_plot_taskgraph) and drops everything under /plot-files/, plus a single HTML page with the images inlined, so you can just open one file and scroll.An example:
https://drive.google.com/file/d/1KRexn-InBLJThMkFplaJGtyhGZP2YgI9/view?usp=drive_link
Merge Checklist
The following items must be completed before PRs can be merged.
Check these off to verify you have completed all steps.
make testRun local tests prior to pushing.make formatFormat source code to comply with lint policies. Note that some lint errors can only be resolved manually (e.g., Python)make lintRun lint on source code prior to pushing.