feat(admin): allow admins to confirm users and set passwords#834
Open
rewritten wants to merge 2 commits intocoopdevs:developfrom
Open
feat(admin): allow admins to confirm users and set passwords#834rewritten wants to merge 2 commits intocoopdevs:developfrom
rewritten wants to merge 2 commits intocoopdevs:developfrom
Conversation
Admins can now create users that are already confirmed (bypassing email confirmation) and optionally set a password at creation time. Existing unconfirmed users can be confirmed via a dedicated action button on their show page. Confirmed-at timestamp is also shown in the user index. Closes coopdevs#821 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Adds admin-side controls to confirm users and optionally set passwords at creation time, reducing reliance on SMTP for provisioning accounts (Issue #821).
Changes:
- Adds an admin “Confirm user” action and shows
confirmed_atin the admin users index. - Extends the ActiveAdmin user form to optionally set password/password confirmation and “Confirm immediately” on create.
- Updates all locales with new i18n keys for the added admin UI.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| config/locales/pt-BR.yml | Adds i18n keys for confirm actions and “confirm immediately”. |
| config/locales/ja.yml | Adds i18n keys for confirm actions and “confirm immediately”. |
| config/locales/gl.yml | Adds i18n keys for confirm actions and “confirm immediately”. |
| config/locales/fr.yml | Adds i18n keys for confirm actions and “confirm immediately”. |
| config/locales/eu.yml | Adds i18n keys for confirm actions and “confirm immediately”. |
| config/locales/es.yml | Adds i18n keys for confirm actions and “confirm immediately”. |
| config/locales/en.yml | Adds i18n keys for confirm actions and “confirm immediately”. |
| config/locales/ca.yml | Adds i18n keys for confirm actions and “confirm immediately”. |
| app/models/user.rb | Introduces confirm_immediately virtual attribute used during admin create. |
| app/admin/user.rb | Adds confirm member action, confirmed_at column, password fields, and create/update overrides for confirmation/password handling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+27
to
+30
| member_action :confirm, method: :put do | ||
| resource.confirm! | ||
| redirect_to admin_user_path(resource), notice: I18n.t("active_admin.users.confirmed_notice") | ||
| end |
There was a problem hiding this comment.
New admin behaviors are introduced here (manual confirmation endpoint and the ability to set/retain passwords via the ActiveAdmin form/controller overrides) but there are no specs covering them. Adding request/controller specs around PUT /admin/users/:id/confirm, create with/without confirm_immediately, and update with blank vs non-blank password would help prevent regressions (especially around Devise confirmable).
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #821
Password/Password confirmationfields and aConfirm immediatelycheckbox — when checked, the user is created already confirmed without needing a working SMTP setupPUT /admin/users/:id/confirmactionconfirmed_atcolumn so confirmation status is visible at a glanceTest plan
confirmed_atshould be set, no confirmation email requiredconfirmed_atshould be set and the button should disappear🤖 Generated with Claude Code