docs: document missing ENV variables for mailing and assets#833
Open
rewritten wants to merge 1 commit intocoopdevs:developfrom
Open
docs: document missing ENV variables for mailing and assets#833rewritten wants to merge 1 commit intocoopdevs:developfrom
rewritten wants to merge 1 commit intocoopdevs:developfrom
Conversation
…opdevs#827) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR updates repository documentation to better reflect the environment variables the Rails app actually reads for production assets and outbound email configuration.
Changes:
- Documents
RAILS_ASSET_HOSTandASSETS_PRECOMPILEin the README ENV table. - Fixes the README env var name to
MAIL_LINK_PROTOto match production config. - Adds
MAILER_SENDERto both the README and.env.examplefor Devise sender configuration.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| README.md | Adds/mends ENV variable documentation for asset hosting/precompile and mailer URL/sender settings. |
| .env.example | Adds MAILER_SENDER example value for local/dev configuration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MAILER_SENDERto README ENV table and.env.example— the sender address for all Devise emails (fixes DocumentMAILER_SENDER#827)MAIL_LINK_PROTOCOL→MAIL_LINK_PROTOin README to match the actual variable name used in the code and.env.exampleRAILS_ASSET_HOSTandASSETS_PRECOMPILEwhich were used inconfig/environments/production.rbbut undocumentedTest plan
.env.examplecontainsMAILER_SENDERwith a sensible placeholder🤖 Generated with Claude Code