Skip to content

fix: disable email delivery when SMTP is not configured #831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rewritten wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix: disable email delivery when SMTP is not configured #831

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5036b96
fix: disable email delivery when SMTP is not configured (fixes #822, …
rewritten Mar 26, 2026
1fbc839
Update config/environments/production.rb
rewritten Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions config/environments/production.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,20 +82,22 @@
# Set this to true and configure the email server for immediate delivery to raise delivery errors.
# config.action_mailer.raise_delivery_errors = false

config.action_mailer.delivery_method = :smtp
config.action_mailer.default_url_options = {
host: ENV["MAIL_LINK_HOST"],
protocol: ENV["MAIL_LINK_PROTO"] || "https"
}

smtp_env = Hash[ENV.map do |k, v|
if /^SMTP_(.*)$/ === k
[$1.downcase.to_sym, YAML.load(v)]
end
end.compact]
smtp_env = ENV.filter { |k, _| k.start_with?("SMTP_") }
.to_h { |k, v| [k.delete_prefix("SMTP_").downcase.to_sym, YAML.load(v)] }
Comment on lines +90 to +91
Copy link

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YAML.load(v) will deserialize arbitrary YAML from environment variables, which can instantiate unexpected Ruby objects and is generally unsafe. Prefer YAML.safe_load (permitting only basic scalar types you expect) or explicit casting (e.g., int/bool parsing) for SMTP settings values.

Copilot uses AI. Check for mistakes.


if smtp_env.present?
config.action_mailer.delivery_method = :smtp
config.action_mailer.smtp_settings = smtp_env
else
config.action_mailer.delivery_method = :test
config.action_mailer.perform_deliveries = false
warn "[TimeOverflow] No SMTP configuration found (SMTP_* env vars). Email delivery is disabled."
end

# Enable locale fallbacks for I18n (makes lookups for any locale fall back to
Expand Down
Loading