MOON tutorial#50
Merged
Merged
Conversation
Signed-off-by: Karim Pedemonte <karim.pedemonte@edu.unige.it>
Signed-off-by: Karim Pedemonte <karim.pedemonte@edu.unige.it>
Signed-off-by: Karim Pedemonte <karim.pedemonte@edu.unige.it>
ct2034
requested changes
Apr 23, 2026
Member
ct2034
left a comment
ct2034
left a comment
There was a problem hiding this comment.
Thanks Karim. I only have some small requests.
Comment on lines
+32
to
+37
| if closed_doors_world: | ||
| world_file = os.path.join( | ||
| get_package_share_directory("tutorial_sim"), | ||
| "worlds", | ||
| "world_closed_doors.yaml", | ||
| ) |
Member
There was a problem hiding this comment.
Could we generalize this to pass a filename, that then by default is world.yaml?
Member
There was a problem hiding this comment.
Similar to how it's done with policy:=bt_tree.xml right now.
Member
There was a problem hiding this comment.
(also changes in tutorials/simulation/tutorial_run/launch/full_simulation.launch.py are required)
Contributor
Author
There was a problem hiding this comment.
I added the suggested change.
Signed-off-by: Karim Pedemonte <karim.pedemonte@edu.unige.it>
ct2034
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the tutorial on MOON