Merged
Conversation
- Add full GPU/CPU parameter support to methods() returning 4-tuples - Implement complete strategy builders with ResolvedMethod support - Enhance registry with parameter-aware strategy mapping - Add comprehensive test coverage (422 tests total): * Component Checks: 26 tests * Component Completion: 29 tests * Descriptive Routing: 75 tests * Kwarg Extraction: 59 tests * Methods: 39 tests * Print: 46 tests * Registry: 65 tests * Strategy Builders: 83 tests - Fix all test failures and ensure 100% pass rate - Add proper dependency handling for strategy building - Support both provided and build paths for strategy construction
- Add tests for is_parameter_type, available_parameters, get_parameter_type - Improve test_registry.jl with parameter validation using CTSolvers functions - Enhance test_dispatch_logic.jl with parametric mocks for parameter testing - Complete test_ctsolvers.jl coverage for all reexported symbols - Fix comment in ctsolvers.jl imports (parameter types are import-only) - Add missing tests for describe and options functions All tests pass with comprehensive coverage of CTSolvers parameter validation functions and proper verification of reexport vs import-only symbols.
- Remove MadNLPMumps import from test_canonical.jl (version conflicts) - Remove MadNLPMumps import from test_explicit.jl (version conflicts) - Update test_solve_modes.jl imports for consistency All tests pass (1169/1169) with clean imports
Contributor
|
Breakage test results
|
- Add test_descriptive.jl for descriptive mode testing - Complete and partial symbolic descriptions - Integration tests with real strategies (Beam, Goddard) - Initial guess aliases (init) - Error handling for unknown strategies - Add test_error_handling_simple.jl for robust error testing - Mode detection conflicts (explicit vs descriptive) - Invalid component types and arguments - Edge cases and boundary conditions - Both test files include proper imports for solver extensions - Tests provide comprehensive coverage of Layer 2 solve functionality
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.