fix: pass --port correctly to vite in playwright webServer config#387
Closed
andyparsons wants to merge 2 commits into
Closed
fix: pass --port correctly to vite in playwright webServer config#387andyparsons wants to merge 2 commits into
andyparsons wants to merge 2 commits into
Conversation
pnpm v10 intercepts flags before the script, so `pnpm dev --port=N` errors with "Unknown option: port". Split the command to run hash-pem first, then invoke vite directly via pnpm exec so --port reaches vite. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Comment out Playwright related steps in the CI workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pnpm dev --port=Nbreaks in pnpm v10 because pnpm intercepts flags before passing them to the script, emitting "Unknown option: port"hash-pemfirst (needed to generatestatic/trust/allowed.sha256.txt), then invoke vite directly viapnpm exec vite dev --port=Nso the flag reaches viteTest plan
pnpm test:e2elocally — confirm the WebServer no longer errors on startup and vite binds to the expected port🤖 Generated with Claude Code