chore: fix all ESLint errors (103 → 0)#385
Open
andyparsons wants to merge 4 commits into
Open
Conversation
- Remove unused imports and variables across 17 files
- Replace `any` types with specific inline types for C2PA assertion
accesses, validation status objects, and trust-annotated manifest types
- Fix unused export prop in AssetInfoIssuerDate (let → const)
- Fix svelte-ignore → eslint-disable-next-line for {@html} in IssuedBySection
- Auto-fixed padding, prefer-const, and shorthand attribute violations
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Fix type errors exposed after ESLint was fixed: replace string-indexed assertion lookups with array .find() by label, add proper type annotations for implicit-any parameters, and remove invalid c2pa module augmentation (package is @contentauth/c2pa-web). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
entries in c2pa.training-mining is a Record<string, {use}>, not an
array — use Object.values().some() instead of .find().
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Reformats long lines in e2e tests, spec files, sdk.ts, and Svelte components to comply with the project's print-width lint rules. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
loadThumbnail,AssetInfoDate,legacyToCrJson,getUntrustedManifestLabels,isCryptoValid, dead reactive declarations, etc.)anytypes with specific inline types for C2PA assertion accesses, validation status objects, and trust-annotated manifest typesAssetInfoIssuerDate(export let→export const)svelte-ignore→eslint-disable-next-linefor{@html}inIssuedBySectionprefer-const, shorthand attributes/imports) viaeslint --fixNote:
svelte-checkreports 45 pre-existing type errors onmainunrelated to these changes (down from 46 — one was incidentally fixed here).Test plan
pnpm run lintpasses with 0 errors (was 103)🤖 Generated with Claude Code