feat: add TSA and certificate support to wasm signer#51
Open
thillmann wants to merge 7 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: 7d0f290 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
thillmann
force-pushed
the
wasm-signer-update
branch
from
97dce78 to
c6a964c
Compare
thillmann
force-pushed
the
wasm-signer-update
branch
from
c6a964c to
fabce4a
Compare
- Use JsString::from instead of JsError::new where the function signature returns Result<_, JsString>. does not implement From<&String>. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Document that the trustConfig setting maps to c2pa-rs's trust_config, which is the list of allowed Extended Key Usage (EKU) OIDs that signing certificates may have. Add a README example showing how to set custom trust anchors plus additional EKUs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
thillmann
force-pushed
the
wasm-signer-update
branch
from
fabce4a to
7d0f290
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to use the
Builderto embed a signed manifest in a media file, we encountered a few gaps:direct_cose_handlingwas always set totrueSignerUsing the Node.js implementation as guidance, I made those changes and confirmed it was working in our sign and embedding flow.