Skip to content

Problems with containers started with --detach=True#182

Merged
TheRealBecks merged 3 commits intomainfrom
issue174
Mar 9, 2026
Merged

Problems with containers started with --detach=True#182
TheRealBecks merged 3 commits intomainfrom
issue174

Conversation

@TheRealBecks
Copy link
Copy Markdown
Collaborator

Fixes #174

@TheRealBecks TheRealBecks linked an issue Feb 9, 2026 that may be closed by this pull request
@TheRealBecks
Copy link
Copy Markdown
Collaborator Author

@k9withabone Is it correct to remove #[serde(skip_serializing)]? I checked other code examples in the repository and they don't have that line in combination with the now more specific #[arg... line.

@k9withabone
Copy link
Copy Markdown
Member

No, #[serde(skip_serializing)] is necessary. --detach is a special case because Quadlet always puts -d in the output .service file's ExecStart= option. So if Podlet does not skip it when setting PodmanArgs= in the .container file, you'll get --detach -d in the output.

@k9withabone
Copy link
Copy Markdown
Member

Also, please try to use conventional commits with a Fixes: footer linking the issue. See the commit message of 79cd688 for an example.

Signed-off-by: Martin Beckert <martin.beckert@strukturpiloten.de>
Podman automatically creates `--detach=True` for the `podman run` command and therefore Podlet needs to take care of it when parsing the Podman command.

Fixes: #174
Signed-off-by: Martin Beckert <martin.beckert@strukturpiloten.de>
Copy link
Copy Markdown
Member

@k9withabone k9withabone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just need to update the branch so that it is based off of the current version of main.

@TheRealBecks TheRealBecks merged commit 8df4387 into main Mar 9, 2026
15 checks passed
@TheRealBecks TheRealBecks deleted the issue174 branch March 9, 2026 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Problems with containers started with --detach=True

2 participants