This repository was archived by the owner on Mar 16, 2021. It is now read-only.
updated the binary name in Dockerfile#8
Open
tparikh wants to merge 1 commit intocontainer-object-storage-interface:masterfrom
Open
updated the binary name in Dockerfile#8tparikh wants to merge 1 commit intocontainer-object-storage-interface:masterfrom
tparikh wants to merge 1 commit intocontainer-object-storage-interface:masterfrom
Conversation
Signed-off-by: Tejas Parikh <tejas@tejasparikh.com>
Author
|
@wlan0 @brahmaroutu PTAL |
Contributor
|
@tparikh we also need to move the code base under cmd/controller-manager for the build tool to be happy. |
Author
|
@brahmaroutu Can you please elaborate on your comment. I am able to build the binary with the current code structure. |
|
Given this project is called |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tejas Parikh tejas@tejasparikh.com