fix: get_animals and get_empty remove nans (fixes #243)#246
Open
abishop1990 wants to merge 2 commits intoconservationtechlab:devfrom
Open
fix: get_animals and get_empty remove nans (fixes #243)#246abishop1990 wants to merge 2 commits intoconservationtechlab:devfrom
abishop1990 wants to merge 2 commits intoconservationtechlab:devfrom
Conversation
- update device handlers - add sequence_calculation() - add best arg to single_classification - update args in export_timelapse() - ensure pandas < 3.0.0
…#243) - Modified get_animals() to remove rows with NaN in category column - Modified get_empty() to remove rows with NaN in category column - Added comprehensive test suite with 16 test cases covering NaN scenarios - All tests pass and code passes flake8 linting Fixes conservationtechlab#243
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the NaN handling in the get_animals and get_empty functions in the split module.
Changes Made
Testing
Related Issues
Fixes #243