fix: detect() function now properly passes file_col parameter to manifest_dataloader (fixes #239)#245
Open
abishop1990 wants to merge 2 commits intoconservationtechlab:devfrom
Open
Conversation
- update device handlers - add sequence_calculation() - add best arg to single_classification - update args in export_timelapse() - ensure pandas < 3.0.0
…fest_dataloader (fixes conservationtechlab#239)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #239 - detect() bug not accepting different file_col parameter
Description
The
detect()function accepts afile_colparameter to specify which column in a manifest contains file paths, but it was not passing this parameter to themanifest_dataloader()function. This caused the dataloader to always use the default 'filepath' column, resulting in errors when users specified a custom column name.Solution
Added the
file_colparameter to themanifest_dataloader()call in thedetect()function (line 206 in src/animl/detection.py), ensuring that custom file path column names are properly propagated through the data pipeline.Changes
src/animl/detection.py: Updated the manifest_dataloader call to pass file_col parameterchanges/239.bugfix.md: Added changelog entryTesting