Added item flag name import/export support - fixes #3#1039
Open
philayres wants to merge 1 commit intoconsected:developfrom
Open
Added item flag name import/export support - fixes #3#1039philayres wants to merge 1 commit intoconsected:developfrom
philayres wants to merge 1 commit intoconsected:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds import support for item flag names in app type configurations and test coverage for import round-trip. Supersedes #1037.
Changes
Import implementation:
import_config_sub_items 'associated_item_flag_names', %w[name item_type]toimport_setinapp/models/admin/app_type_import.rbassociated_general_selectionsimport (item flags depend on table types being available)Import test coverage:
Spec comment:
Files changed
app/models/admin/app_type_import.rb— Added import line forassociated_item_flag_namesspec/models/admin/app_type_import_spec.rb— Added import round-trip test and comment