Fix & complete find_imports for AST visitor#103
Open
zdivelbiss wants to merge 3 commits intoconnorskees:masterfrom
Open
Fix & complete find_imports for AST visitor#103zdivelbiss wants to merge 3 commits intoconnorskees:masterfrom
find_imports for AST visitor#103zdivelbiss wants to merge 3 commits intoconnorskees:masterfrom
Conversation
Author
|
@connorskees any way I can get some feedback on this PR, and potentially get it merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the existing implementation of
fn find_imports() -> Option<PathBuf>to a finished implementation that follows the Sass specifications, as well as fixing loading for stylesheets that are compiled directly, rather than loaded from the filesystem (i.e. viagrass::from_stringrather thangrass::from_file).This should also resolve #88.