Skip to content

IMessageStore extended with method SetAndIncrNextSenderMsgSeqNum, resolves issue #987#993

Merged
gbirchmeier merged 3 commits into
connamara:masterfrom
asmeisne:issue/987
Apr 23, 2026
Merged

IMessageStore extended with method SetAndIncrNextSenderMsgSeqNum, resolves issue #987#993
gbirchmeier merged 3 commits into
connamara:masterfrom
asmeisne:issue/987

Conversation

@asmeisne
Copy link
Copy Markdown

@asmeisne asmeisne commented Jan 26, 2026

The IMessageStore interface is extended with a new method SetAndIncrNextSenderMsgSeqNum with a default implementation to ensure backwards compatibility. This new method now is used in Session.Persist() to allow execution of methods IMessageStore.Set() and IMessageStore.IncrNextSenderMsgSeqNum() in one transaction. Two unit tests for FileStore and MemoryStore are added.

resolves #987

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jan 26, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ gbirchmeier
❌ ameisner-boerse
You have signed the CLA already but the status is still pending? Let us recheck it.

@gbirchmeier
Copy link
Copy Markdown
Member

gbirchmeier commented Apr 8, 2026

@asmeisne Can you please click this link to sign the CLA? Thanks!

https://cla-assistant.io/connamara/quickfixn?pullRequest=993

gbirchmeier added a commit to asmeisne/quickfixn that referenced this pull request Apr 8, 2026
@gbirchmeier
Copy link
Copy Markdown
Member

I rebased to latest master, moved the functions to be closer to the others, and changed the doc-comment a little. I will merge as soon as you accept the CLA!

@mirkosowalabs
Copy link
Copy Markdown

@gbirchmeier how can we move this pull request forward from @asmeisne ?

@gbirchmeier
Copy link
Copy Markdown
Member

@mirkosowalabs It took me like 3 months to act on asmeisne's report. I think it's fair to give him more than 2 days to respond.

@asmeisne
Copy link
Copy Markdown
Author

@asmeisne Can you please click this link to sign the CLA? Thanks!

https://cla-assistant.io/connamara/quickfixn?pullRequest=993

@gbirchmeier I already signed the CLA as asmeisne but the comment above shows that signing is required by ameisner-boerse. Since I am no more member of boerse-stuttgart, I do not have access to this account anymore. Can you fix this?

@gbirchmeier
Copy link
Copy Markdown
Member

Thanks for the explanation, that seems sufficient!

@gbirchmeier gbirchmeier merged commit 2bdf3a5 into connamara:master Apr 23, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Request: new interface method IMessageStore.SetAndIncrNextSenderMsgSeqNum to enable single-lock set-and-increment, for db-based store implementations

5 participants