Skip to content

Add pin-policy-bundle acceptance tests for TA task#3324

Open
joejstuart wants to merge 1 commit into
conforma:mainfrom
joejstuart:policy-digest-acceptance
Open

Add pin-policy-bundle acceptance tests for TA task#3324
joejstuart wants to merge 1 commit into
conforma:mainfrom
joejstuart:policy-digest-acceptance

Conversation

@joejstuart
Copy link
Copy Markdown
Contributor

Summary

  • Add pin-policy-bundle step log assertion to the existing "Golden container image with trusted artifacts" scenario (no-op path: policy uses git sources, OCI tag not found)
  • Add new "Pin policy bundle digest" scenario for verify-conforma-konflux-ta task (replacement path: OCI tag replaced with digest-pinned reference)
  • Add corresponding snapshot entries

These mirror the two pin-policy-bundle scenarios already covered by the verify-enterprise-contract task, closing a gap where the TA task variant had zero dedicated coverage for this step.

Test plan

  • Acceptance tests pass for ta_task_validate_image feature

🤖 Generated with Claude Code

The verify-conforma-konflux-ta task had no test coverage for the
pin-policy-bundle step. Mirror the two scenarios already covered by the
verify-enterprise-contract task: the no-op path (policy uses git
sources) and the replacement path (policy uses the OCI tag reference).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 26, 2026

Warning

Review limit reached

@joejstuart, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 38 minutes. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 09e5acf5-5aa2-45ff-a515-8da6cb82a834

📥 Commits

Reviewing files that changed from the base of the PR and between 8aec709 and 36c805b.

⛔ Files ignored due to path filters (1)
  • features/__snapshots__/ta_task_validate_image.snap is excluded by !**/*.snap
📒 Files selected for processing (1)
  • features/ta_task_validate_image.feature
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
acceptance 55.60% <ø> (ø)
generative 17.82% <ø> (ø)
integration 26.56% <ø> (ø)
unit 69.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joejstuart
Copy link
Copy Markdown
Contributor Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant