MINOR: push playwright trace files as job artifacts#3313
Merged
Dave Shoup (shouples) merged 1 commit intomainfrom Mar 9, 2026
Merged
MINOR: push playwright trace files as job artifacts#3313Dave Shoup (shouples) merged 1 commit intomainfrom
Dave Shoup (shouples) merged 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Semaphore CI pipelines for Playwright E2E runs so the generated Playwright HTML report archive is uploaded not only as a workflow artifact but also as a job artifact, making it easier to download traces/reports from an individual job page.
Changes:
- Push Playwright report archive as a Semaphore job artifact in the Makefile-based flow.
- Push Playwright report archive as a Semaphore job artifact in the Windows Playwright E2E pipeline block.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
mk-files/semaphore.mk |
Adds an artifact push job upload for the merged Playwright report archive. |
.semaphore/playwright-e2e.yml |
Adds an artifact push job upload for the Windows merged Playwright report archive. |
|
James Robinson (jlrobins)
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already push them as workflow artifacts, but this makes it easier to look at a specific job (logs or otherwise) and download the associated trace file.
Current workflow artifacts:
Current job artifacts (nothing useful for test failure triage):
Ref: https://docs.semaphore.io/using-semaphore/artifacts