-
Notifications
You must be signed in to change notification settings - Fork 23
[MATRIX-1193] Add username/password option for elastic self hosted #3215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Aitor Algorta (AitorAlgorta)
wants to merge
8
commits into
main
Choose a base branch
from
MATRIX-1193
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
fd2d8f3
[MATRIX-1193] Add username/password option for elastic self hosted
AitorAlgorta 7125ad5
[MATRIX-1193] Add username/password to tests
AitorAlgorta 3ca1e1f
[MATRIX-1193] Add whitespaces to match test
AitorAlgorta 955d657
Add elastic tests
AitorAlgorta 7a015fd
Add flink_test
AitorAlgorta 6189a17
Fix elastic tests
AitorAlgorta 508fccd
feat(flink): Edit Elastic connection
AitorAlgorta 03db4db
feat(flink): Fix elastic golden files trailing newlines
AitorAlgorta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 changes: 36 additions & 0 deletions
36
test/fixtures/output/flink/connection/create/create-elastic-missing-required-secret.golden
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| Error: if any flags in the group [username password] are set they must all be set; missing [password] | ||
| Usage: | ||
| confluent flink connection create <name> [flags] | ||
|
|
||
| Examples: | ||
| Create Flink connection "my-connection" in AWS us-west-2 for OpenAPI with endpoint and API key. | ||
|
|
||
| $ confluent flink connection create my-connection --cloud aws --region us-west-2 --type openai --endpoint https://api.openai.com/v1/chat/completions --api-key 0000000000000000 | ||
|
|
||
| Flags: | ||
| --cloud string REQUIRED: Specify the cloud provider as "aws", "azure", or "gcp". | ||
| --region string REQUIRED: Cloud region for Flink (use "confluent flink region list" to see all). | ||
| --type string REQUIRED: Specify the connection type as "openai", "azureml", "azureopenai", "a2a", "bedrock", "sagemaker", "googleai", "vertexai", "mongodb", "elastic", "pinecone", "couchbase", "confluent_jdbc", "rest", or "mcp_server". | ||
| --endpoint string REQUIRED: Specify endpoint for the connection. | ||
| --api-key string Specify API key for the type: "openai", "azureml", "azureopenai", "googleai", "elastic", "pinecone", "a2a", or "mcp_server". | ||
| --aws-access-key string Specify access key for the type: "bedrock" or "sagemaker". | ||
| --aws-secret-key string Specify secret key for the type: "bedrock" or "sagemaker". | ||
| --aws-session-token string Specify session token for the type: "bedrock" or "sagemaker". | ||
| --service-key string Specify service key for the type: "vertexai". | ||
| --username string Specify username for the type: "mongodb", "elastic", "couchbase", "confluent_jdbc", "a2a", "rest", or "mcp_server". | ||
| --password string Specify password for the type: "mongodb", "elastic", "couchbase", "confluent_jdbc", "a2a", "rest", or "mcp_server". | ||
| --token string Specify bearer token for the type: "a2a", "rest", or "mcp_server". | ||
| --token-endpoint string Specify OAuth2 token endpoint for the type: "a2a", "rest", or "mcp_server". | ||
| --client-id string Specify OAuth2 client ID for the type: "a2a", "rest", or "mcp_server". | ||
| --client-secret string Specify OAuth2 client secret for the type: "a2a", "rest", or "mcp_server". | ||
| --scope string Specify OAuth2 scope for the type: "a2a", "rest", or "mcp_server". | ||
| --sse-endpoint string Specify SSE endpoint for the type: "mcp_server". | ||
| --transport-type string Specify transport type for the type: "mcp_server". Default: SSE. | ||
| --environment string Environment ID. | ||
| -o, --output string Specify the output format as "human", "json", or "yaml". (default "human") | ||
|
|
||
| Global Flags: | ||
| -h, --help Show help for this command. | ||
| --unsafe-trace Equivalent to -vvvv, but also log HTTP requests and responses which might contain plaintext secrets. | ||
| -v, --verbose count Increase verbosity (-v for warn, -vv for info, -vvv for debug, -vvvv for trace). | ||
|
|
36 changes: 36 additions & 0 deletions
36
test/fixtures/output/flink/connection/create/create-elastic-mutually-exclusive-secret.golden
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| Error: if any flags in the group [username password] are set they must all be set; missing [password] | ||
| Usage: | ||
| confluent flink connection create <name> [flags] | ||
|
|
||
| Examples: | ||
| Create Flink connection "my-connection" in AWS us-west-2 for OpenAPI with endpoint and API key. | ||
|
|
||
| $ confluent flink connection create my-connection --cloud aws --region us-west-2 --type openai --endpoint https://api.openai.com/v1/chat/completions --api-key 0000000000000000 | ||
|
|
||
| Flags: | ||
| --cloud string REQUIRED: Specify the cloud provider as "aws", "azure", or "gcp". | ||
| --region string REQUIRED: Cloud region for Flink (use "confluent flink region list" to see all). | ||
| --type string REQUIRED: Specify the connection type as "openai", "azureml", "azureopenai", "a2a", "bedrock", "sagemaker", "googleai", "vertexai", "mongodb", "elastic", "pinecone", "couchbase", "confluent_jdbc", "rest", or "mcp_server". | ||
| --endpoint string REQUIRED: Specify endpoint for the connection. | ||
| --api-key string Specify API key for the type: "openai", "azureml", "azureopenai", "googleai", "elastic", "pinecone", "a2a", or "mcp_server". | ||
| --aws-access-key string Specify access key for the type: "bedrock" or "sagemaker". | ||
| --aws-secret-key string Specify secret key for the type: "bedrock" or "sagemaker". | ||
| --aws-session-token string Specify session token for the type: "bedrock" or "sagemaker". | ||
| --service-key string Specify service key for the type: "vertexai". | ||
| --username string Specify username for the type: "mongodb", "elastic", "couchbase", "confluent_jdbc", "a2a", "rest", or "mcp_server". | ||
| --password string Specify password for the type: "mongodb", "elastic", "couchbase", "confluent_jdbc", "a2a", "rest", or "mcp_server". | ||
| --token string Specify bearer token for the type: "a2a", "rest", or "mcp_server". | ||
| --token-endpoint string Specify OAuth2 token endpoint for the type: "a2a", "rest", or "mcp_server". | ||
| --client-id string Specify OAuth2 client ID for the type: "a2a", "rest", or "mcp_server". | ||
| --client-secret string Specify OAuth2 client secret for the type: "a2a", "rest", or "mcp_server". | ||
| --scope string Specify OAuth2 scope for the type: "a2a", "rest", or "mcp_server". | ||
| --sse-endpoint string Specify SSE endpoint for the type: "mcp_server". | ||
| --transport-type string Specify transport type for the type: "mcp_server". Default: SSE. | ||
| --environment string Environment ID. | ||
| -o, --output string Specify the output format as "human", "json", or "yaml". (default "human") | ||
|
|
||
| Global Flags: | ||
| -h, --help Show help for this command. | ||
| --unsafe-trace Equivalent to -vvvv, but also log HTTP requests and responses which might contain plaintext secrets. | ||
| -v, --verbose count Increase verbosity (-v for warn, -vv for info, -vvv for debug, -vvvv for trace). | ||
|
|
1 change: 1 addition & 0 deletions
1
test/fixtures/output/flink/connection/create/create-elastic-no-secret.golden
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Error: no secrets provided for type elastic, one of the required secrets "[api-key]" or "[username password]" must be provided |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Just double-checking, this removal of
api-keyoption is intentional, right?