Conversation
On Conductor instances older than v5, POSTing to /tasks/update-v2 returns 405 (Method Not Allowed) rather than 404 (Not Found). This happens because the wildcard GET handler @GetMapping("/{taskId}") matches the path, causing Spring MVC to reject the POST with 405 instead of a plain 404. The previous fix only checked for status 404, so the fallback to the v1 update endpoint never triggered on Conductor 4.x, leaving task updates failing after 4 retries. Changes: - Check e.status in (404, 405) in both TaskRunner and AsyncTaskRunner - Log the actual HTTP status code in the warning message - Add unit test covering the 405 fallback case
v1r3n
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Conductor instances older than v5, the SDK's fallback from
update-task-v2to the v1 update endpoint was not triggering.The previous fix (#387) only checked for HTTP 404. However, Conductor 4.x returns 405 (Method Not Allowed) instead of 404 when the SDK POSTs to
/tasks/update-v2. This happens because the wildcardGET /{taskId}route in Conductor'sTaskResourcematches the path — Spring MVC sees a known path with the wrong method and returns 405 rather than 404.As a result, task updates failed after exhausting all 4 retries with no fallback, breaking workers entirely on Conductor 4.x.
Changes
e.status in (404, 405)in bothTaskRunnerandAsyncTaskRunnerValidation
Tested against a locally built Conductor 4.1.66 instance. Confirmed the following log sequence when the SDK connects to Conductor 4.x:
All subsequent task updates go directly to v1 with no further retries.