Skip to content

CLUE-450 Seismic Shared Model#2792

Merged
tealefristoe merged 23 commits intomasterfrom
seismic-shared-model
Mar 16, 2026
Merged

CLUE-450 Seismic Shared Model#2792
tealefristoe merged 23 commits intomasterfrom
seismic-shared-model

Conversation

@tealefristoe
Copy link
Copy Markdown
Contributor

@tealefristoe tealefristoe commented Mar 12, 2026

Jira stories:
https://concord-consortium.atlassian.net/browse/CLUE-450
https://concord-consortium.atlassian.net/browse/CLUE-451
https://concord-consortium.atlassian.net/browse/CLUE-458
https://concord-consortium.atlassian.net/browse/CLUE-459

This PR:

  • Adds a new Timeline tile with a dummy toolbar.
  • Adds a new SharedSeismogram model.
  • Allows users to load data in the Wave Runner tile, which will then display in the tile (takes ~50 seconds).
  • Allows users to create Timeline tiles via a Timeline It! button in the Wave Runner toolbar.
  • Timeline tiles display the same waveform as their creating Wave Runner tile. The information is shared through a SharedSeismogram model.

Note that this whole project is a work in progress, and many of the features included in this PR are incomplete or suboptimal. We'll be cleaning things up in future PRs.

tealefristoe and others added 9 commits March 7, 2026 14:57
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Add SharedSeismogram model with volatile seismogram, isLoading,
  loadError state and a loadData() flow action that fetches miniseed
  files from S3
- Register SharedSeismogram for WaveRunner and Timeline tile types
- Move WaveformPanel component into shared-seismogram plugin
- Update WaveRunnerContentModel to create/delegate to SharedSeismogram,
  add isWaveRunnerContentModel type guard
- Wire Load Data and Timeline It! toolbar buttons using TileModelContext
  and AddTilesContext.addTileAfter
- Update StatusAndOutput to read seismogram from shared model (no more
  auto-fetch on mount)
- Update TimelineContentModel to expose seismogram from linked
  SharedSeismogram, add isTimelineContentModel type guard
- Render full waveform in timeline tile when SharedSeismogram has data

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@tealefristoe tealefristoe marked this pull request as draft March 12, 2026 02:46
@cypress
Copy link
Copy Markdown

cypress Bot commented Mar 12, 2026

collaborative-learning    Run #18085

Run Properties:  status check passed Passed #18085  •  git commit 752ddbf2ad: Add FIXME.
Project collaborative-learning
Branch Review seismic-shared-model
Run status status check passed Passed #18085
Run duration 03m 24s
Commit git commit 752ddbf2ad: Add FIXME.
Committer Teale Fristoe
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
View all changes introduced in this branch ↗︎

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 12, 2026

Codecov Report

❌ Patch coverage is 85.18519% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.91%. Comparing base (314d658) to head (752ddbf).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
.../plugins/wave-runner/models/wave-runner-content.ts 64.00% 9 Missing ⚠️
src/plugins/wave-runner/wave-runner-toolbar.tsx 64.00% 9 Missing ⚠️
src/plugins/timeline/timeline-toolbar.tsx 78.57% 6 Missing ⚠️
src/register-tile-types.ts 0.00% 5 Missing ⚠️
src/plugins/timeline/components/timeline.tsx 85.71% 1 Missing and 1 partial ⚠️
...ugins/wave-runner/components/status-and-output.tsx 92.85% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (314d658) and HEAD (752ddbf). Click for more details.

HEAD has 32 uploads less than BASE
Flag BASE (314d658) HEAD (752ddbf)
cypress-regression 15 0
cypress 17 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2792       +/-   ##
===========================================
- Coverage   85.99%   66.91%   -19.09%     
===========================================
  Files         858      863        +5     
  Lines       47084    47265      +181     
  Branches    12242    12276       +34     
===========================================
- Hits        40492    31626     -8866     
- Misses       6579    15604     +9025     
- Partials       13       35       +22     
Flag Coverage Δ
cypress ?
cypress-regression ?
cypress-smoke 42.81% <10.37%> (-0.08%) ⬇️
jest 50.99% <85.11%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tealefristoe tealefristoe marked this pull request as ready for review March 14, 2026 14:14
@tealefristoe tealefristoe requested a review from scytacki March 14, 2026 14:14
Copy link
Copy Markdown
Member

@scytacki scytacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. 👍

@tealefristoe tealefristoe merged commit d2a21d5 into master Mar 16, 2026
10 of 12 checks passed
@tealefristoe tealefristoe deleted the seismic-shared-model branch March 16, 2026 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants