Skip to content

Add immersion freezing#205

Open
tangwhiap wants to merge 172 commits intocompdyn:masterfrom
tangwhiap:imf
Open

Add immersion freezing#205
tangwhiap wants to merge 172 commits intocompdyn:masterfrom
tangwhiap:imf

Conversation

@tangwhiap
Copy link
Copy Markdown
Collaborator

Add the immersion freezing simulation codes, freezing test case, and freezing scenario.

tangwhiap and others added 30 commits August 29, 2023 15:24
@slayoo
Copy link
Copy Markdown
Collaborator

slayoo commented Feb 27, 2026

melting covered!
image

@jcurtis2
Copy link
Copy Markdown
Collaborator

  • if (immersion_freezing_scheme_type == IMMERSION_FREEZING_SCHEME_ABIFM) in ice_nucleation_immersion_freezing_time_dependent_naive

This appears to be a false-positive in codecov as I've added print statements that are printed when running test_freezing_4.sh. I tried a few things to try to reorganize the code so it might detect that it is indeed tested with line continuations and optimization reduction.

Also, there are two instances where the following comment is placed:

! FIXME: Do this to avoid compiler warning/error, fix it in the future.

I've changed this to a WORKAROUND so that we do not actually insinuate that we can fix this problem 48b0a85 rather than a FIXME.

tangwhiap and others added 5 commits March 13, 2026 17:44
Co-authored-by: Jeffrey Curtis <jcurtis2@illinois.edu>
Co-authored-by: Jeffrey Curtis <jcurtis2@illinois.edu>
Co-authored-by: Jeffrey Curtis <jcurtis2@illinois.edu>
@slayoo
Copy link
Copy Markdown
Collaborator

slayoo commented Mar 19, 2026

closing & reopening to trigger rebuilt against current master branch

@slayoo slayoo closed this Mar 19, 2026
@slayoo slayoo reopened this Mar 19, 2026
@slayoo
Copy link
Copy Markdown
Collaborator

slayoo commented Mar 25, 2026

@jcurtis2, @nriemer, @mwest1066, let's merge (and release, and unveil PyPartMC 2.0)!

@jcurtis2 jcurtis2 self-requested a review March 27, 2026 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants