fix(ui): a11y skip link + focus rings for info links and refresh button#113
Merged
Conversation
…nel links and refresh button Completes the remaining a11y work from #79 and #80 that the mission control redesign (#103) did not cover: - Add a "Skip to map" link as the first focusable child of <body> so keyboard users can bypass the header and jump straight to #map. - Add `.info-link:focus-visible` so the seven info-panel anchors show the same accent outline as `.ctl:focus-visible`-styled controls. - Add Tailwind focus-visible utilities to the inline "Refresh Page" button in the map-error overlay (white outline against its green background). All focus rings follow the existing house style (outline + accent token) established by the mission control redesign. Closes #79 Closes #80
Deploying veeam-data-cloud-services-map with
|
| Latest commit: |
330f1e4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6323d53f.veeam-data-cloud-services-map.pages.dev |
| Branch Preview URL: | https://fix-a11y-skip-link-focus-rin.veeam-data-cloud-services-map.pages.dev |
There was a problem hiding this comment.
Pull request overview
This PR addresses remaining accessibility gaps in the single-page map UI (layouts/index.html) by adding a keyboard “skip to content” affordance and consistent :focus-visible styling for key links/buttons.
Changes:
- Added a “Skip to map” link at the top of
<body>with new.skip-linkstyling. - Added
:focus-visibleoutline/offset styling for.info-linkanchors in the info panel. - Added
focus-visibleoutline utilities to the “Refresh Page” button in the map error overlay.
- Skip-link focus ring now uses var(--text) instead of var(--accent) so it has clear contrast against both the link's green background and the page bg in either theme (per Copilot review). - Added tabindex="-1" to #map so the skip link reliably transfers keyboard focus, not just the viewport, before Leaflet inits and in the #mapError fallback (per Copilot review). - Updated the "should be keyboard navigable" Playwright test to verify the skip link becomes the first tab stop and adjusted subsequent assertions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the remaining a11y gaps from #79 and #80. The mission control redesign (#103) already covered part of each issue — the
aria-live="polite"on the region counter (for #80) and the shared.ctl:focus-visiblerule that styles all five top-bar control buttons (for #79). This PR finishes the rest:<a href="#map" class="skip-link">Skip to map</a>is inserted as the first child of<body>. Hidden offscreen until focused, then slides in with the accent background. (Closes a11y: add skip-to-content link and aria-live region for filter results #80.).info-link:focus-visible— All seven info-panel anchors (GitHub, API docs, Veeam product, three issue-template links, etc.) now show the same accent outline as.ctl:focus-visible.location.reload()button in the#mapErroroverlay getsfocus-visible:outline-2 focus-visible:outline-offset-2 focus-visible:outline-whiteso the outline is visible against the green background. This button uses Tailwind utility classes for everything else, so the focus styles match local context rather than the design-token approach used elsewhere.All other focus rings follow the established house style:
outline: 2px solid var(--accent)with a 2px offset, keeping them theme-aware (visible in both dark and light modes).Test plan
renderMapvia DevTools), Tab to the Refresh Page button — white outline visible against the green background.var(--accent)is theme-aware so rings should remain visible.pr-validation.yml,validate-data.yml) passes.🤖 Generated with Claude Code