Open
Conversation
Contributor
Author
|
oh it's got bugs but no idea where, that's fun |
Contributor
Author
|
well I'm dumb, the error was me formatting wrong |
ColdAnkles
reviewed
Aug 6, 2020
Contributor
ColdAnkles
left a comment
ColdAnkles
left a comment
There was a problem hiding this comment.
Reviewed this (finally, and as a review not a comment)
- class-magical-girl.xml should be version 0.0.1 as it counts based on versions in the repo, and this will be v1.
- The display of the Transformation feature on the sheet is a large text block that doesn't look great, especially the list of available weapons. Consider paraphrasing.
- reddit-unearthed-arcana.index needs to be updated to version 0.0.4 (I think) since other commits updated it since you started.
ColdAnkles
suggested changes
Aug 21, 2020
ColdAnkles
suggested changes
Aug 21, 2020
ColdAnkles
suggested changes
Nov 25, 2020
Contributor
ColdAnkles
left a comment
ColdAnkles
left a comment
There was a problem hiding this comment.
I think the index and classes.xml need a go-over again, but the magical girl xml is good to go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes both of these content requests
#12
#16
For the record I didn't make the file, but I did change sources and IDs to match the other XMLs