Added Gunslinger Class#3
Open
Azzzzzy wants to merge 12 commits intocommunity-elements:masterfrom
Azzzzzy:class-gunslinger
Open
Added Gunslinger Class#3Azzzzzy wants to merge 12 commits intocommunity-elements:masterfrom Azzzzzy:class-gunslinger
Azzzzzy wants to merge 12 commits intocommunity-elements:masterfrom
Azzzzzy:class-gunslinger
Conversation
NickVendel
requested changes
Oct 23, 2019
Collaborator
NickVendel
left a comment
There was a problem hiding this comment.
I didn't sleep last night, so checked this file in half-asleep state, take comments with grain of salt (and there's also some stuff i probably missed... like the fact there's no links to the article within elements)
NickVendel
requested changes
Oct 27, 2019
Collaborator
NickVendel
left a comment
There was a problem hiding this comment.
Some things from previous review weren't addressed. Also, after everything is solved, whole file still needs to have "url setters"
Contributor
Author
|
Still don't know how exactly to deal with Edit: Found a way to fix it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Gunslinger Class
https://www.dandwiki.com/wiki/Gunslinger_(5e_Class)