Add option to remove banner image#863
Merged
Airyzz merged 10 commits intocommetchat:mainfrom Mar 30, 2026
Merged
Conversation
Airyzz
reviewed
Mar 25, 2026
Contributor
Airyzz
left a comment
Airyzz
left a comment
There was a problem hiding this comment.
Looks pretty good! just a few small changes please
| key, | ||
| '', | ||
| { | ||
| 'url': '', |
Contributor
There was a problem hiding this comment.
i think the content should just be {}
| ), | ||
| Expanded( | ||
| child: tiamat.Button( | ||
| text: "Remove Image", |
Contributor
There was a problem hiding this comment.
Could you please make sure all added text across the whole PR is translatable
Contributor
Author
|
Thanks! The strings have now been changed to intl messages. "Remove" and "Cancel" were added to |
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This creates a new UI molecule
image_select_dialog.dart, which provides an intermediate dialog with options to remove or select a new image. The button text frompicker_utils.dartfor "Use Original Image" has been changed to "Use Without Cropping" in order to make the button's function clearer. The dialog has been implemented for changing user profile banner and space banner. The previous implementation only had one option to select a new image and no way to remove the existing one, if a user wanted to not have a banner at all. This solution closes #801 and could serve as a platform for selecting possible future image editing features if the need arises.Profile banner:
Profile_Banner.mp4
Space banner:
Space_Banner.mp4