Conversation
|
Thank you for the PR! If i'm not mistaken, this looks like mostly a duplicate of the work done in #525. probably the best approach would be for me to merge that PR in to main, and then you can apply your changes over the top of that |
I think that's a good idea, I can make this PR dependent on that one, I missed it completely. But there are some things missing from that PR
So I think both are beneficial |
|
@Airyzz I've made some additional changes and now commet is fully functional on MacOS. I connected to my matrix homeserver and started using it :) I'm still happy to build off the other PR if necessary |
I have access to an MacOS computer (and iPads), so I thought I could have a stab at getting the build working. I've been working a lot with dart and flutter for my research platform, and have had to deal with some similar issues (with the exception of rust libs, I've been using C FFI native libs).
I'm looking for some feedback on this PR, both in terms of scope and how you would like to have it chunked.
What this PR does already:
Untested yet:
Not working on MacOS:
important: While using the
maingithub version of the applemedia_kit_*packages fixes the main problem that broke the build, obviously pointing to the head of a repo is dangerous. Would you prefer:any is fine for me, once I know I can update the PR.
Thanks!
Edit: I wanted to make it clear that none of the changes in the PR, nor the text above used generative AI.