Skip to content

Fix MacOS build#837

Open
zeyus wants to merge 5 commits intocommetchat:mainfrom
zeyus:feature/osx-build
Open

Fix MacOS build#837
zeyus wants to merge 5 commits intocommetchat:mainfrom
zeyus:feature/osx-build

Conversation

@zeyus
Copy link
Copy Markdown

@zeyus zeyus commented Mar 13, 2026

I have access to an MacOS computer (and iPads), so I thought I could have a stab at getting the build working. I've been working a lot with dart and flutter for my research platform, and have had to deal with some similar issues (with the exception of rust libs, I've been using C FFI native libs).

I'm looking for some feedback on this PR, both in terms of scope and how you would like to have it chunked.

What this PR does already:

  • Makes the build for MacOS work
    • Adds required entitlements and Info.plist entries
  • Allows commet to launch and work on MacOS, including connecting to a homeserver, seeing messages, etc

Untested yet:

  • iOS, while I added the required entries for camera and mic to the Info.plist, I haven't built and tested iOS yet

Not working on MacOS:

  • Emoji - no exception but they show up empty

important: While using the main github version of the apple media_kit_* packages fixes the main problem that broke the build, obviously pointing to the head of a repo is dangerous. Would you prefer:

  • Pointing to a specific commit hash
  • That I make a fork / branch
  • That commetchat org makes a fork / branch

any is fine for me, once I know I can update the PR.

Thanks!

Edit: I wanted to make it clear that none of the changes in the PR, nor the text above used generative AI.

@Airyzz
Copy link
Copy Markdown
Contributor

Airyzz commented Mar 14, 2026

Thank you for the PR!

If i'm not mistaken, this looks like mostly a duplicate of the work done in #525. probably the best approach would be for me to merge that PR in to main, and then you can apply your changes over the top of that

@zeyus
Copy link
Copy Markdown
Author

zeyus commented Mar 14, 2026

Thank you for the PR!

If i'm not mistaken, this looks like mostly a duplicate of the work done in #525. probably the best approach would be for me to merge that PR in to main, and then you can apply your changes over the top of that

I think that's a good idea, I can make this PR dependent on that one, I missed it completely.

But there are some things missing from that PR

  • no Info.plist changes to required permission
  • no .entitlements (without plist and entitlements no mic/cam/etc support)
  • no media lib changes, the build fails without using the patched /head version

So I think both are beneficial

@zeyus zeyus mentioned this pull request Mar 18, 2026
@zeyus
Copy link
Copy Markdown
Author

zeyus commented Mar 18, 2026

@Airyzz I've made some additional changes and now commet is fully functional on MacOS. I connected to my matrix homeserver and started using it :)

I'm still happy to build off the other PR if necessary

@zeyus zeyus marked this pull request as ready for review March 18, 2026 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants