pakistan holidays#138
Conversation
| type: observance | ||
| name: | ||
| en: Pakistan Day | ||
| 02-01: |
There was a problem hiding this comment.
is it 1st February or 05-01 = 1st May?
| PK: | ||
| names: | ||
| en: Pakistan | ||
| langs: [] |
There was a problem hiding this comment.
Could you please add the languages used in this data?
e.g.
- en
- ur (Urdu)
It would be nice if you could also add local languages if available e.g. Urdu
| name: | ||
| en: Kashmir Solidarity Day | ||
| 03-23: | ||
| type: observance |
There was a problem hiding this comment.
Can you pls. check if "type" is correct.
See https://github.com/commenthol/date-holidays/blob/master/docs/specification.md#types-of-holidays
observance means that there that some people celebrate the day
public instead means there is some kind of law which declares the day as public holiday
| type: observance | ||
| name: | ||
| en: Quaid-e-Azam's Birthday | ||
| # states: |
There was a problem hiding this comment.
Would it be possible for you to add also muslim holidays? You can find them here https://github.com/commenthol/date-holidays/blob/master/docs/specification.md#hijra-dates. Maybe some of them could apply to Pakistan.
|
Hi, thanks for your PR. Can you please check CONTRIBUTING.md and run to have your changes fixed in some testcases? Thanks. |
|
@professorhaseeb : it would be great to add support for Pakistan. Could you address @commenthol's comments and questions? |
3 participants
Pakistan's Public holiday