Skip to content

data channel double counting#10

Merged
stefpi merged 5 commits intomasterfrom
fix/datachannel-double-counting
Apr 15, 2026
Merged

data channel double counting#10
stefpi merged 5 commits intomasterfrom
fix/datachannel-double-counting

Conversation

@stefpi
Copy link
Copy Markdown
Contributor

@stefpi stefpi commented Mar 11, 2026

avoid problematic double counting of data channels (firefox mainly) by:

  • counting video/audio and data channels separately
  • allowing only 1 data channel to be added which matches the implementation of _number_of_incoming_media
    added test: test_parse_incoming_streams_datachannel_counting to tests/test_stream.py

stefpi and others added 2 commits March 11, 2026 16:39
Co-Authored-By: Keyvan Fatehi <keyvanfatehi@gmail.com>
@stefpi stefpi requested a review from adeebshihadeh March 11, 2026 23:51
@stefpi stefpi marked this pull request as draft March 16, 2026 23:02
@stefpi stefpi changed the title Fix/datachannel double counting better webrtc support for firefox Mar 16, 2026
@stefpi stefpi removed the request for review from adeebshihadeh March 17, 2026 02:06
@stefpi stefpi force-pushed the fix/datachannel-double-counting branch from 8ee3c53 to eddfd44 Compare March 25, 2026 21:52
@stefpi stefpi marked this pull request as ready for review March 26, 2026 01:29
@stefpi stefpi marked this pull request as draft March 27, 2026 22:36
@stefpi stefpi marked this pull request as ready for review April 14, 2026 01:29
@stefpi stefpi marked this pull request as draft April 14, 2026 23:47
@stefpi stefpi changed the title better webrtc support for firefox data channel double counting Apr 15, 2026
@stefpi stefpi marked this pull request as ready for review April 15, 2026 00:09
@stefpi stefpi merged commit 22df577 into master Apr 15, 2026
12 checks passed
@stefpi stefpi deleted the fix/datachannel-double-counting branch April 15, 2026 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants