Skip to content

require minimum Python version 3.12.13 when using uv#37637

Merged
adeebshihadeh merged 1 commit intocommaai:masterfrom
greatgitsby:claude/update-python-version-uv-PyYuS
Mar 10, 2026
Merged

require minimum Python version 3.12.13 when using uv#37637
adeebshihadeh merged 1 commit intocommaai:masterfrom
greatgitsby:claude/update-python-version-uv-PyYuS

Conversation

@greatgitsby
Copy link
Copy Markdown
Contributor

@greatgitsby greatgitsby commented Mar 10, 2026

released! https://github.com/astral-sh/python-build-standalone/releases/tag/20260310

s/o to @andiradulescu for getting the patches merged.

Update requires-python from >=3.12.3 to >=3.12.13 to match the CPython 3.12.13 release in python-build-standalone 20260310.

This build contains the time patch needed to work on comma devices with older glibc.

References:

@greatgitsby greatgitsby force-pushed the claude/update-python-version-uv-PyYuS branch from 011a76f to 1f3f5d8 Compare March 10, 2026 21:02
@greatgitsby greatgitsby marked this pull request as ready for review March 10, 2026 21:08
@adeebshihadeh
Copy link
Copy Markdown
Contributor

This isn't an ideal solution: any Python 3.12 is fine, we're just doing this to force a particular build for the uv-managed Python. Really what you want is two settings: "compatible Python versions" and "if using uv, install this one".

I'm fine with it though if there's no other way (provided there is a comment explaining this inline).

…0310

Add .python-version pinning Python to 3.12.13 to match the CPython
3.12.13 release in python-build-standalone 20260310. The pyproject.toml
floor stays at >=3.12.3.

This build contains the time patch needed to work on comma devices with
older glibc.

References:
- astral-sh/python-build-standalone#985
- commaai#33993 (comment)
@greatgitsby greatgitsby force-pushed the claude/update-python-version-uv-PyYuS branch from 1f3f5d8 to 52e5229 Compare March 10, 2026 21:38
@greatgitsby greatgitsby changed the title require minimum Python version 3.12.13 require minimum Python version 3.12.13 when using uv Mar 10, 2026
@greatgitsby
Copy link
Copy Markdown
Contributor Author

lot simpler!

@greatgitsby
Copy link
Copy Markdown
Contributor Author

@adeebshihadeh
Copy link
Copy Markdown
Contributor

Noooooo another top level file.... nothing we can add to the pyproject instead? (This is still better than what was there before)

@greatgitsby
Copy link
Copy Markdown
Contributor Author

https://docs.astral.sh/uv/concepts/python-versions/#minor-version-directories

the only other option noted there is to specify the python version when running uv. we could do that in setup.sh. thoughts?

@adeebshihadeh
Copy link
Copy Markdown
Contributor

Ok if those are really our full set of options, this is the most complete I think.

@adeebshihadeh adeebshihadeh merged commit dd89bc3 into commaai:master Mar 10, 2026
10 checks passed
@greatgitsby greatgitsby deleted the claude/update-python-version-uv-PyYuS branch March 11, 2026 04:35
FrogAi pushed a commit to FrogAi/FrogPilot that referenced this pull request Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants