clip: load metadata params within OpenpilotPrefix#37634
Merged
adeebshihadeh merged 1 commit intocommaai:masterfrom Mar 10, 2026
Merged
clip: load metadata params within OpenpilotPrefix#37634adeebshihadeh merged 1 commit intocommaai:masterfrom
adeebshihadeh merged 1 commit intocommaai:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the clip tool to avoid polluting the user’s/main Params namespace by loading route metadata only after entering an OpenpilotPrefix (isolated params directory) context.
Changes:
- Move
load_route_metadata(route)invocation inside theOpenpilotPrefix(...)context so Params writes are isolated/cleaned up.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
FrogAi
pushed a commit
to FrogAi/FrogPilot
that referenced
this pull request
Apr 3, 2026
fix: move metadata loading inside OpenpilotPrefix context
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running the clip tool, it pollutes the main params with all the params from the route (dongle ID, firehose stats, etc).
The fix is to move the metadata loading to within the OpenpilotPrefix context.