Conversation
Contributor
UI Previewmici: |
sshane
reviewed
Mar 10, 2026
Comment on lines
-125
to
-127
| if not long_man_enabled: | ||
| self._long_maneuver_toggle.action_item.set_state(False) | ||
| self._params.put_bool("LongitudinalManeuverMode", False) |
Contributor
There was a problem hiding this comment.
is there anything that resets on second onroad transition?
Contributor
Author
There was a problem hiding this comment.
CLEAR_ON_OFFROAD_TRANSITION in params_keys.h
Confirmed it resets in Lexus on mici.
Contributor
|
This PR has had no activity for 24 days. It will be automatically closed in 7 days if there is no activity. |
Contributor
|
This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes. |
Contributor
Process replay diff reportReplays driving segments through this PR and compares the behavior to master. ✅ 0 changed, 66 passed, 0 errors |
karelnagel
pushed a commit
to asiusai/openpilot
that referenced
this pull request
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #37623