Skip to content

fix: re-fetch route list after closing direct-link route view #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sshane wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: re-fetch route list after closing direct-link route view #594

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91765d1
fix: re-fetch route list after closing direct-link route view
sshane Apr 30, 2026
baff7ee
fire checkRoutesData on dashboard mount
sshane Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions src/actions/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,13 @@ export function checkRoutesData() {
console.debug('We need to update the segment metadata...');
const { dongleId } = state;
const fetchRange = state.filter;
// Direct visits to /dongleId/log_id fetch only that one route for speed.
// Remember that so we don't claim to have covered the full filter range —
// otherwise hasRoutesData lies and the dashboard never re-fetches when the
// user clicks X to close the route view.
const isSegmentFetch = !!state.segmentRange;

// if requested segment range not in loaded routes, fetch it explicitly
if (state.segmentRange) {
if (isSegmentFetch) {
routesRequest = {
req: Drives.getRoutesSegments(dongleId, undefined, undefined, undefined, `${dongleId}|${state.segmentRange.log_id}`),
dongleId,
Expand Down Expand Up @@ -95,8 +99,11 @@ export function checkRoutesData() {
dispatch({
type: Types.ACTION_ROUTES_METADATA,
dongleId,
start: fetchRange.start,
end: fetchRange.end,
// null start/end means "we did not cover the full filter range" so the
// next checkRoutesData (e.g. when the user closes back to the dashboard)
// will refetch all routes for the active filter.
start: isSegmentFetch ? null : fetchRange.start,
end: isSegmentFetch ? null : fetchRange.end,
routes,
});

Expand Down
2 changes: 1 addition & 1 deletion src/components/Dashboard/DriveList.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ const DriveList = (props) => {

return (
<div className={classes.drivesTable}>
<VisibilityHandler onVisible={() => dispatch(checkRoutesData())} minInterval={60} />
<VisibilityHandler onInit onVisible={() => dispatch(checkRoutesData())} minInterval={60} />
{content}
{contentStatus}
</div>
Expand Down
Loading