Closed
Conversation
Author
|
Closed in favor of #34. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.
What changed?
✳️ rubocop (~> 0.76 → ~> 1.12) · Repo · Changelog
Release Notes
1.12.1
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 28 commits:
Cut 1.12.1Update ChangelogDocument that we allow parens where omitting them is ambiguous or invalidParenthesized forwarded args in Style/MethodCallWithArgsParenthesesConfigure rspec shared_context_metadata_behavior to :apply_to_host_groups (compatibility for rspec 4)[Fix #9672] Fix an incorrect auto-correct for `Style/HashConversion`Merge pull request #9671 from koic/fix_incorrect_autocorrect_for_ambiguous_operatorFix an incorrect auto-correct for `Lint/AmbiguousOperator`Remove (almost) redundant setting.Merge pull request #9646 from koic/fix_incorrect_autocorrect_for_style_and_orMerge pull request #9649 from osyo-manga/fix_when_highlights_contain_multibyte_charactersFix when highlights contain multibyte charactersFix an incorrect auto-correct for `Style/AndOr`Merge pull request #9645 from koic/fix_incorrect_autocorrect_for_style_single_line_methodsFix an incorrect auto-correct for `Style/SingleLineMethods`Merge pull request #9639 from marcotc/fix/RedundantBegin-remove-commentsTweak offense message for `Lint/NumberConversion`Merge pull request #9644 from koic/fix_error_for_style_multiline_method_signatureMerge pull request #9642 from dvandersluis/issue/9641Fix an error for `Style/MultilineMethodSignature`Merge pull request #9643 from amomchilov/patch-2[Fix #9641] Fix `Layout/MultilineMethodCallIndentation` triggering on method calls that look like operators.Update frozen_string_literal_comment.rbFix `Style/RedundantBegin` removing comments on assignment statement correctionFix an error for `Layout/LineLength`Tweak the doc for `Style/AccessModifierDeclarations`[Fix #9608] Fix a false positive for `Layout/EmptyLineAfterGuardClause`Switch back the docs version to masterDepfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.All Depfu comment commands