Closed
Conversation
Author
|
Closed in favor of #30. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.
What changed?
✳️ rubocop (~> 0.76 → ~> 1.9) · Repo · Changelog
Release Notes
1.9.1
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 39 commits:
Cut 1.9.1Update Changelog[Fix #9453] Fix an infinite loop error for `Layout/FirstParameterIndentation`[Fix #9465] Update `Metrics/ParameterLists` to be able to write `MaxOptionalParameters` in rubocop_todo.yml.Deprecate `ConfigurableMax` in favour of `ExcludeLimit` which allows multiple configuration options to be added to the exclude limit for `--auto-gen-config`.Merge pull request #9485 from koic/support_co_contributor_signatureSupport co-contributor signature for changelog buildAvoid tap.Fix `StyleGuideBaseURL` not functioning with nested departmentsMark `Style/IfWithBooleanLiteralBranche` as unsafe auto-correction[Fix #9454] Fix an incorrect auto-correct for `Style/IfWithBooleanLiteralBranches`[Fix #9459] Add `AllowedMethods` option to `Style/IfWithBooleanLiteralBranches`[Fix #9473] Fix an error for `Lint/DeprecatedConstants`Merge pull request #9451 from koic/fix_an_error_for_sole_nested_conditionalMerge pull request #9443 from dvandersluis/issue/9437[Docs] Improve the listing of cop extensions[Docs] Tweak some markup[Docs] Mention rubocop-sorbetFix typo: "as it its" → "as its" (#9474)minor typo: "aim the ease" -> "aim to ease"Merge pull request #9468 from dvandersluis/issue/9466[Fix #9437] Improve offense message when there is an allowed range of empty lines.Merge pull request #9467 from koic/fix_a_false_positive_for_lint_symbol_conversion[Fix #9457] Fix a false positive for `Lint/SymbolConversion`Merge pull request #9456 from koic/fix_false_positive_for_lint_symbol_conversion[Fix #9466] Don't correct `Style/SingleLineMethods` using endless methods if the target ruby is < 3.0.[Fix #9455] Fix a false positive for `Lint/SymbolConversion`[Fix #9448] Fix an error for `Style/SoleNestedConditional`[Fix #9449] Fix an error for `Style/NilComparison`[Fix #9438] Fix a false positive for `Layout/SpaceBeforeBrackets`Merge pull request #9447 from tejasbubane/fix-9444[Fix #9431] Fix an error for `Style/DisableCopsWithinSourceCodeDirective`[Fix #9444] Fix error on colorization for offenses with `Severity: info`Merge pull request #9442 from dvandersluis/issue-9440Merge pull request #9435 from koic/fix_an_error_for_style_eval_with_location[Fix #9440] Fix `Lint/SymbolConversion` for implicit `to_sym` without a receiver.[Fix #9433] Fix an error for `Style/EvalWithLocation`Fix the changelogSwitch back the docs version to masterDepfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.All Depfu comment commands