Conversation
GitHub App 移行(docs/github-app-migration.md Phase 0-A)の先行実施。 PAT 期間中に admin が他 org のリポを操作できないよう、リポジトリの 追加・削除を owner ロールに限定する。 - isOrgOwner / requireOrgOwner を追加 - repositories.add の loader/action に owner ガードを適用 - repository settings の delete action に owner ガードを適用(update は全ロール許可) - UI: 非 owner には Add ボタン・DangerZone を非表示 - fix: ChangeRoleDialog の form.reset() が Dialog マウント前に呼ばれるバグを修正 - docs: GitHub App 移行計画を追加 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughowner ロール判定関数を追加し、リポジトリの追加・削除をオーナーに限定する認可ゲートをサーバー側(loader/action)に導入。フロントは所有権に基づくボタン表示を制御し、メンバー操作ダイアログのマウントを遅延させる変更を含む。 Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant Route as "Route Loader/Action"
participant Auth as "auth.server"
participant RepoSvc as "Repository logic"
Client->>Route: リクエスト (loader/action)
Route->>Auth: requireOrgOwner(membership, orgSlug)?
alt isOrgOwner == true
Auth-->>Route: OK
Route->>RepoSvc: 続行(データ取得 / 処理)
RepoSvc-->>Route: 結果
Route-->>Client: 返却 / 正常処理
else not owner
Auth-->>Route: redirect
Route-->>Client: redirect to /:orgSlug/settings/repositories
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/github-app-migration.md`:
- Around line 46-56: The two fenced code blocks (the one beginning "既存
App「upflow-team」を techtalkjp org に Transfer + 権限追加" and the later block
beginning "1. クライアントに GitHub App インストールを依頼") are missing a language identifier
and trigger markdownlint MD040; update both opening triple-backtick lines to use
a language specifier such as ```text (or another appropriate language), leaving
the block contents unchanged, so the fences become ```text ... ``` for both
occurrences.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: d9881f63-3476-4c89-b18d-0aa9bf3f4eee
📒 Files selected for processing (10)
app/libs/auth.server.tsapp/libs/member-role.test.tsapp/libs/member-role.tsapp/routes/$orgSlug/settings/members/+components/member-row-actions.tsxapp/routes/$orgSlug/settings/repositories._index/+components/data-table-toolbar.tsxapp/routes/$orgSlug/settings/repositories._index/+components/repo-table.tsxapp/routes/$orgSlug/settings/repositories._index/index.tsxapp/routes/$orgSlug/settings/repositories.add/index.tsxapp/routes/$orgSlug/settings/repositories/$repository/settings/index.tsxdocs/github-app-migration.md
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Summary
docs/github-app-migration.md)の Phase 0-A を実施isOrgOwner/requireOrgOwnerを追加し、リポ操作ルートに適用form.reset()が Dialog マウント前に呼ばれるバグを修正(条件付きレンダリングで remount する方式に変更)Test plan
/settings/repositories/addに直接アクセスするとリダイレクトされることCloses #243
🤖 Generated with Claude Code
Summary by CodeRabbit