Skip to content

feat: Improved initial prompt handling#142

Merged
35C4n0r merged 11 commits intocoder:mainfrom
35C4n0r:feat-splash-detection
Nov 24, 2025
Merged

feat: Improved initial prompt handling#142
35C4n0r merged 11 commits intocoder:mainfrom
35C4n0r:feat-splash-detection

Conversation

@35C4n0r
Copy link
Copy Markdown
Collaborator

@35C4n0r 35C4n0r commented Nov 12, 2025

Example - Opencode agent:

running -> stable (we send initial prompt on first stable) -> running (this is the part where it finally shows the splash screen and the agent is ready to accept input).

The PR tries to fix this by taking into account whether the input box is visible or not.

@35C4n0r 35C4n0r self-assigned this Nov 12, 2025
@35C4n0r 35C4n0r marked this pull request as draft November 12, 2025 03:42
@35C4n0r 35C4n0r marked this pull request as ready for review November 12, 2025 13:25
@github-actions
Copy link
Copy Markdown

✅ Preview binaries are ready!

To test with modules: agentapi_version = "agentapi_142" or download from: https://github.com/coder/agentapi/releases/tag/agentapi_142

@35C4n0r 35C4n0r requested review from johnstcn and matifali November 12, 2025 13:48
Copy link
Copy Markdown
Collaborator

@hugodutka hugodutka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test in conversation_test.go to check if the new logic behaves correctly.

Comment thread lib/msgfmt/testdata/initialization/opencode/ready/msg.txt Outdated
Comment thread lib/msgfmt/agent_readiness.go Outdated
Comment thread lib/msgfmt/agent_readiness.go
Comment thread lib/msgfmt/agent_readiness.go Outdated
Comment thread lib/screentracker/conversation.go Outdated
@35C4n0r
Copy link
Copy Markdown
Collaborator Author

35C4n0r commented Nov 18, 2025

resolved all the comments.

Comment thread lib/msgfmt/agent_readiness_test.go Outdated
Comment thread lib/screentracker/conversation.go Outdated
Comment thread lib/screentracker/conversation.go Outdated
Comment thread lib/screentracker/conversation_test.go Outdated
Comment thread lib/screentracker/conversation_test.go Outdated
Comment thread lib/screentracker/conversation_test.go Outdated
Comment thread lib/screentracker/conversation.go Outdated
@35C4n0r 35C4n0r requested a review from mafredri November 21, 2025 16:42
@35C4n0r
Copy link
Copy Markdown
Collaborator Author

35C4n0r commented Nov 21, 2025

@mafredri resolved all the comments.

Comment thread lib/screentracker/conversation_test.go
Comment thread lib/screentracker/conversation_test.go
@35C4n0r 35C4n0r merged commit e81a744 into coder:main Nov 24, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants