feat: add new dot-path array helpers#9990
Open
michalsn wants to merge 5 commits intocodeigniter4:4.8from
Open
Conversation
datamweb
reviewed
Feb 23, 2026
Comment on lines
+62
to
+63
| explode('.', $trimmed), | ||
| static fn ($s): bool => $s !== '', |
Contributor
There was a problem hiding this comment.
For micro-optimization, how about using the first-class callable strlen(...) instead of a closure to filter out empty strings while safely keeping '0'?
Suggested change
| explode('.', $trimmed), | |
| static fn ($s): bool => $s !== '', | |
| explode('.', $trimmed), | |
| strlen(...), |
| if ($index === '*') { | ||
| $result = []; | ||
|
|
||
| continue; |
Contributor
There was a problem hiding this comment.
Since the array becomes completely empty here, wouldn’t using break instead of continue be more efficient to avoid processing any remaining keys?
Suggested change
| continue; | |
| break; |
paulbalandan
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR:
dot_array_has(),dot_array_set(),dot_array_unset(),dot_array_only(), anddot_array_except(), each backed by a correspondingArrayHelperstatic method.ArrayHelper::dotKeyExists()todotHas()and updates all callers, includingValidation/Rules.phpandValidation/StrictRules/Rules.php. This is a safe change sinceArrayHelperis marked as@internal.ArrayHelper::convertToArray()that usesexplode()for the common case (no escaped dots), avoiding PCRE engine overhead.Checklist: