fix(config): recognize disabled zlib compression values#10193
Open
memleakd wants to merge 1 commit into
Open
Conversation
memleakd
force-pushed
the
fix/frankenphp-zlib-output-compression
branch
from
9cb872c to
f5ad0cb
Compare
memleakd
changed the title
michalsn
reviewed
May 12, 2026
|
👋 Hi, @memleakd! |
memleakd
force-pushed
the
fix/frankenphp-zlib-output-compression
branch
from
89acc58 to
f25d5af
Compare
- accept Off as a disabled zlib.output_compression value - keep the zlib output-buffer guard active for enabled values - update the 4.7.3 changelog Signed-off-by: memleakd <121398829+memleakd@users.noreply.github.com>
memleakd
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #10192
This PR updates the app starter’s
zlib.output_compressionguard to recognize valid disabled ini values. The previous guard used a loose truthiness check:This can reject valid disabled values such as
"Off"because PHP treats non-empty strings as truthy.The guard now allows disabled values:
and still rejects enabled values. This keeps the output-buffer protection in place while avoiding false failures when PHP reports
zlib.output_compressionas"Off".The 4.7.3 changelog is updated.
Checklist: