Skip to content

chore: Add Structarmed to QA#10180

Merged
paulbalandan merged 10 commits into
codeigniter4:developfrom
samsonasik:chore-add-structarmed
May 11, 2026
Merged

chore: Add Structarmed to QA#10180
paulbalandan merged 10 commits into
codeigniter4:developfrom
samsonasik:chore-add-structarmed

Conversation

@samsonasik
Copy link
Copy Markdown
Member

@samsonasik samsonasik commented May 10, 2026

Description

This is continue of PR that detected by Structarmed

to automate architecture definition check on github workflows.

https://github.com/boundwize/structarmed

Structarmed is configurable PHP architecture guards, this we can define layers and rules, then keep them enforced.

On early of this PR, only check PSR4 usage. Use pinned version 0.3.4 on purpose to ease catch bug isolation when new version released.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value (without duplication)
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@github-actions github-actions Bot added the github_actions Pull requests that update Github_actions code label May 10, 2026
@samsonasik
Copy link
Copy Markdown
Member Author

Ready for review/merge 👍

@samsonasik
Copy link
Copy Markdown
Member Author

The Structarmed github caching seems not reliable for now, I will try improve later, but this seems should be ok for now, as it pretty fast :)

@neznaika0
Copy link
Copy Markdown
Contributor

I don't see any practical benefit from the package yet. Perhaps it will grow further into something similar to deptrac...

@samsonasik
Copy link
Copy Markdown
Member Author

It trades deptrac's flexibility and maturity for a dramatically lower setup cost, opinionated presets, PHP-native config, and PHPUnit integration out of the box.

@samsonasik
Copy link
Copy Markdown
Member Author

samsonasik commented May 10, 2026

Btw, just bumped structarmed to 0.3.3 to properly fix cache on CI workflow, tested in my own repo samsonasik/ArrayLookup#44

This should be ok now 👍

@samsonasik
Copy link
Copy Markdown
Member Author

Bumped to 0.3.4 to fix very long list progressbar 👍

@samsonasik samsonasik force-pushed the chore-add-structarmed branch from 2983333 to f84f71d Compare May 11, 2026 15:13
@samsonasik
Copy link
Copy Markdown
Member Author

samsonasik commented May 11, 2026

Rebased and bumped to 0.3.5 for allow use psr-12 preset, can be enabled later if needed after this PR merged ;)

Ready for merge 👍

@samsonasik samsonasik force-pushed the chore-add-structarmed branch from f84f71d to 1e18dad Compare May 11, 2026 15:52
Comment thread .github/workflows/test-structarmed.yml
Comment thread .github/workflows/test-structarmed.yml Outdated
Comment thread .github/workflows/test-structarmed.yml Outdated
@samsonasik samsonasik requested a review from paulbalandan May 11, 2026 16:11
Copy link
Copy Markdown
Member

@paulbalandan paulbalandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approving this, but let's wait for another review. Thanks!

Copy link
Copy Markdown
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this can eventually replace deptrack, I'm good with it.

@paulbalandan paulbalandan merged commit 37ee0ee into codeigniter4:develop May 11, 2026
51 checks passed
@paulbalandan
Copy link
Copy Markdown
Member

Thank you, @samsonasik

@samsonasik samsonasik deleted the chore-add-structarmed branch May 11, 2026 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update Github_actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants