Skip to content

chore: use single class per file when possible on tests/ directory#10176

Merged
samsonasik merged 2 commits intocodeigniter4:developfrom
samsonasik:chore-use-single-class-per-file
May 9, 2026
Merged

chore: use single class per file when possible on tests/ directory#10176
samsonasik merged 2 commits intocodeigniter4:developfrom
samsonasik:chore-use-single-class-per-file

Conversation

@samsonasik
Copy link
Copy Markdown
Member

@samsonasik samsonasik commented May 9, 2026

Description

So it can match psr-4 definition. This is detected by my structarmed tool:

https://github.com/boundwize/structarmed

for psr4 preset, this is one of functionality, define layers and rules, then keep them enforced.

I can add structarmed to be part of CI later if needed.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value (without duplication)
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@github-actions github-actions Bot added the testing Pull requests that changes tests only label May 9, 2026
@samsonasik samsonasik force-pushed the chore-use-single-class-per-file branch from 66ea0f8 to 272bd4b Compare May 9, 2026 10:38
@github-actions github-actions Bot removed the testing Pull requests that changes tests only label May 9, 2026
@samsonasik
Copy link
Copy Markdown
Member Author

Ready for review/merge 👍

Copy link
Copy Markdown
Contributor

@neznaika0 neznaika0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with your opinion

@samsonasik
Copy link
Copy Markdown
Member Author

Thank you @MGatner @neznaika0 @paulbalandan for the review, let's merge 👍

@samsonasik samsonasik merged commit 7446d0b into codeigniter4:develop May 9, 2026
53 checks passed
@samsonasik samsonasik deleted the chore-use-single-class-per-file branch May 9, 2026 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants