chore: use single class per file when possible on tests/ directory#10176
Merged
samsonasik merged 2 commits intocodeigniter4:developfrom May 9, 2026
Merged
Conversation
66ea0f8 to
272bd4b
Compare
Member
Author
|
Ready for review/merge 👍 |
MGatner
approved these changes
May 9, 2026
neznaika0
approved these changes
May 9, 2026
Contributor
neznaika0
left a comment
There was a problem hiding this comment.
I agree with your opinion
paulbalandan
approved these changes
May 9, 2026
Member
Author
|
Thank you @MGatner @neznaika0 @paulbalandan for the review, let's merge 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
So it can match psr-4 definition. This is detected by my
structarmedtool:https://github.com/boundwize/structarmed
for psr4 preset, this is one of functionality, define layers and rules, then keep them enforced.
I can add
structarmedto be part of CI later if needed.Checklist: