fix: PostgreSQL Builder's increment() and decrement() methods not working for numeric columns#10172
Open
patel-vansh wants to merge 3 commits intocodeigniter4:developfrom
Open
Conversation
Contributor
|
Isn't the current test tests/system/Database/Live/IncrementTest.php running for postgresql? |
Contributor
Author
Well, yes, I deliberately added that new file because I thought that testing increment for numeric columns was explicit to PostgreSQL, but you're right, I will add that to the normal file only so that other DB builders also get tested with numeric columns. |
michalsn
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As discovered in #10140 in this comment, the PostgreSQL Builder's
increment()anddecrement()methods were giving errors while incrementing/decrementing numeric columns.This PR fixes that by changing
"to_number({$column}, '9999999') + {$value}"to"CAST({$column} AS numeric) + {$value}", so that both string as well as numeric columns work as expected.Checklist: