Skip to content

refactor: remove PHPStan callable signature baseline#10166

Open
memleakd wants to merge 2 commits intocodeigniter4:developfrom
memleakd:refactor/phpstan-callable-types
Open

refactor: remove PHPStan callable signature baseline#10166
memleakd wants to merge 2 commits intocodeigniter4:developfrom
memleakd:refactor/phpstan-callable-types

Conversation

@memleakd
Copy link
Copy Markdown
Contributor

@memleakd memleakd commented May 6, 2026

Description
Adds PHPDoc callable signatures where PHPStan reported missing callable parameter/return signatures.

This removes all entries from missingType.callable.neon, deletes the now-empty baseline file, and removes its loader include. It also removes one related assign.propertyType baseline entry for Table::$function, since the property PHPDoc now supports the invalid callback string tested in TableTest.

Related to #6310.

Verification:

  • composer phpstan:check
  • git diff --check

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value (without duplication)
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

Signed-off-by: memleakd <121398829+memleakd@users.noreply.github.com>
@memleakd memleakd force-pushed the refactor/phpstan-callable-types branch from 7740173 to c1658d6 Compare May 6, 2026 21:48
Comment thread system/View/Table.php Outdated
Comment thread system/BaseModel.php Outdated
Signed-off-by: memleakd <121398829+memleakd@users.noreply.github.com>
@paulbalandan
Copy link
Copy Markdown
Member

This needs rebasing too but wait until the other cleanup is merged to reduce duplicate effort. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants